fix(knowledge): reject nested theme doc candidates - #5808
Conversation
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Analysis Report
No new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | View full report |
6dd9bb0 to
c73f61c
Compare
cixzhang
left a comment
cixzhang
left a comment
There was a problem hiding this comment.
Thanks, this closes the false-green path for misplaced nested theme records. This is an approve once you undraft.
[Reviewed by Robohands]
c73f61c to
531a941
Compare
cixzhang
left a comment
cixzhang
left a comment
There was a problem hiding this comment.
Thanks, I rechecked the rebased head. Only unrelated guidance changed around it, so the false-green fix remains an approve once you undraft.
[Reviewed by Robohands]
531a941 to
471a7ba
Compare
cixzhang
left a comment
cixzhang
left a comment
There was a problem hiding this comment.
Thanks, I rechecked the second mechanical rebase. Main contributed only unrelated AppShell test coverage, so the false-green fix remains an approve once you undraft.
[Reviewed by Robohands]
|
Closing at the author's request. |
1 participant
Summary
docs/themesexcept the regular rootREADME.mdFocused follow-up to #5792.
Test plan
pnpm exec vitest run --project node scripts/check-knowledge.test.mjs .github/scripts/change-scope.test.mjs .github/scripts/spec-owner-reconcile.test.mjs .github/scripts/spec-owner-workflow.test.mjspnpm check:knowledge --base origin/mainpnpm check:repoNo Changeset: this changes repository validation only.